-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider setting DAPR_HTTP_PORT and DAPR_GRPC_PORT in DaprDistributedApplicationLifecycleHook #4077
Labels
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
area-dapr
Comments
dotnet-issue-labeler
bot
added
the
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
label
May 3, 2024
...which is what they will be relying on when deployed:
|
...and DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT were only added July 2023: ...I am guessing, but are these only configured when deployed if using Diagrid Catalyst, rather than Dapr alone? |
...and they are not documented: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
area-dapr
Currently, when adding a Dapr sidecar, the DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT environment variables are set:
aspire/src/Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs
Lines 148 to 152 in 31ce95b
Some apps may instead rely on DAPR_HTTP_PORT and/or DAPR_GRPC_PORT and will therefore fail.
See also:
https://github.com/dapr/dotnet-sdk/blob/ba1341510bfc81f0e1ba4687539ec49aa90abc4e/src/Shared/DaprDefaults.cs#L63-L76
The text was updated successfully, but these errors were encountered: