Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspire.Hosting.Dapr should allow specifying CLI executable location #2219

Open
ReubenBond opened this issue Feb 14, 2024 · 3 comments · May be fixed by #4081
Open

Aspire.Hosting.Dapr should allow specifying CLI executable location #2219

ReubenBond opened this issue Feb 14, 2024 · 3 comments · May be fixed by #4081
Assignees
Milestone

Comments

@ReubenBond
Copy link
Member

To allow consuming the dapr CLI in a GitHub Actions workflow, I believe we should support picking up the CLI from an env var value or allow some other way to specify it. Currently, it only checks some fixed locations. For context, see this comment: dotnet/aspire-samples#108 (comment)

cc @philliphoff

@joperezr
Copy link
Member

@davidfowl
Copy link
Member

davidfowl commented Feb 15, 2024

Can we find it on the path as an option? There’s already a way to specify the path in the call to AddDapr

@davidfowl davidfowl added this to the Backlog milestone Mar 10, 2024
@DamianEdwards
Copy link
Member

I'm working around this in the samples CI now by capturing the Dapr CLI path output from the step that installs it and injecting it as an environment variable to the build and test steps. Then the AppHost project has code like this:

// Workaround for https://github.com/dotnet/aspire/issues/2219
if (builder.Configuration.GetValue<string>("DAPR_CLI_PATH") is { } daprCliPath)
{
    builder.Services.Configure<DaprOptions>(options =>
    {
        options.DaprPath = daprCliPath;
    });
}

@philliphoff philliphoff self-assigned this May 3, 2024
@philliphoff philliphoff linked a pull request May 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants