Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify UseSwaggerUI is only called in dev mode. #32418

Closed
Rick-Anderson opened this issue Apr 26, 2024 · 2 comments
Closed

Verify UseSwaggerUI is only called in dev mode. #32418

Rick-Anderson opened this issue Apr 26, 2024 · 2 comments
Assignees
Labels
seQUESTered Identifies that an issue has been imported into Quest.

Comments

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Apr 26, 2024

Wait until @Rick-Anderson signs off that he has made a first pass.

Review internal list of UseSwaggerUI and verify there are no naked calls.
Look at the URL and skip any URLs that contain docs. which indicates a localized version.


Associated WorkItem - 248596

@Rick-Anderson Rick-Anderson added the reQUEST Triggers an issue to be imported into Quest label Apr 26, 2024
@tdykstra
Copy link
Contributor

Wait until @Rick-Anderson signs off that he has made a first pass.

Waiting...

@sequestor sequestor bot added seQUESTered Identifies that an issue has been imported into Quest. and removed reQUEST Triggers an issue to be imported into Quest labels Apr 26, 2024
@Rick-Anderson
Copy link
Contributor Author

Wait until @Rick-Anderson signs off that he has made a first pass.

Review internal list of UseSwaggerUI and verify there are no naked calls. Look at the URL and skip any URLs that contain docs. which indicates a localized version.

Associated WorkItem - 248596

UPDATED work
Any localized content should be deleted. I think I got almost all of them.
Rather than review for naked calls, make sure you can see UseSwaggerUI in the query results. I've been adding // UseSwaggerUI is called only in Development. so we can see in the query output we can see the that // UseSwaggerUI is called only in Development.

I've finished the first pass so @tdykstra can take over the morning of Monday 29 April.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
Development

No branches or pull requests

3 participants