Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSwag.AspNetCore 14 does not contain definition for UseSwaggerUi3 #31455

Closed
Magnus-K-work opened this issue Jan 16, 2024 · 3 comments · Fixed by #31669
Closed

NSwag.AspNetCore 14 does not contain definition for UseSwaggerUi3 #31455

Magnus-K-work opened this issue Jan 16, 2024 · 3 comments · Fixed by #31669
Assignees
Labels
doc-bug seQUESTered Identifies that an issue has been imported into Quest. Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@Magnus-K-work
Copy link

Magnus-K-work commented Jan 16, 2024

Description

As of version 14 of NSwag.AspNetCore, the configuration method UseSwaggerUi3 has been renamed UseSwaggerUi. Please update the linked documentation.

Reference for this changed method name:
RicoSuter/NSwag#4524

Page URL

https://learn.microsoft.com/en-us/aspnet/core/tutorials/getting-started-with-nswag?view=aspnetcore-8.0&tabs=visual-studio

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/tutorials/getting-started-with-NSwag.md

Document ID

25f7fb5b-92b0-a45b-57ab-fdceab571884

Article author

@zuckerthoben


Associated WorkItem - 200667

@dotnet-bot dotnet-bot added ⌚ Not Triaged Source - Docs.ms Docs Customer feedback via GitHub Issue labels Jan 16, 2024
@Rick-Anderson Rick-Anderson self-assigned this Jan 17, 2024
@Rick-Anderson Rick-Anderson added doc-bug reQUEST Triggers an issue to be imported into Quest and removed ⌚ Not Triaged labels Jan 17, 2024
@github-actions github-actions bot added seQUESTered Identifies that an issue has been imported into Quest. and removed reQUEST Triggers an issue to be imported into Quest labels Jan 17, 2024
@timdeschryver
Copy link
Contributor

I can pick this one up if you'd like.

I just need some guidance how a change like this needs to be documented in the docs.
Do we just replace the implementation, or do we add a comment to document both versions?
For example:

// Using NSWag V14
app.UseSwaggerUi();  

// Using NSwag V13
app.UseSwaggerUi3();

For context:

  • NSwag v13 has by far the most downloads (according to NuGet)
  • NSwag v13 has .NET 5 - .NET 7 support
  • NSwag v14 has .NET 6 - .NET 8 support

@Magnus-K-work
Copy link
Author

Do we just replace the implementation, or do we add a comment to document both versions? For example:

// Using NSWag V14
app.UseSwaggerUi();  

// Using NSwag V13
app.UseSwaggerUi3();

For context:

  • NSwag v13 has by far the most downloads (according to NuGet)
  • NSwag v13 has .NET 5 - .NET 7 support
  • NSwag v14 has .NET 6 - .NET 8 support

^ This would have helped me. Great suggestion!

@Rick-Anderson
Copy link
Contributor

@timdeschryver

Do we just replace the implementation, or do we add a comment to document both versions?
Just replace to the new UI.
Thanks for taking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-bug seQUESTered Identifies that an issue has been imported into Quest. Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
No open projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

4 participants