You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The file .mvn/maven.config is used to set the release build information and release version to use for the build. If this file accidentally made it into the trunk branch we would no longer be building the default 1.0.0-SNAPSHOT versioning, this would break the build/deploy and possibly be a security issue also. An input flag should be used to initialize, by default the existence of the file should trigger failure, for a workflow/branch that expects a release version then a regex can be provided that the version contained in the .mvn/maven.config must match, in this case if the file does not exist it should error
A check should also be added to the pre-commit script in core-web/.husky/pre-commit so a user can be notified that the .mvn/maven.config is in the git index and should not before commit will work. A user should never commit this file to any branch directly. Make sure this logic is not running in CICD though that would prevent the promote step from working.
The text was updated successfully, but these errors were encountered:
spbolton
changed the title
Add check to PR workflow (initialize step) to fail if .mvn/maven.config exists. This should only be in release branches
Add check to PR workflow (initialize step) to fail if .mvn/maven.config exists
May 14, 2024
The file .mvn/maven.config is used to set the release build information and release version to use for the build. If this file accidentally made it into the trunk branch we would no longer be building the default 1.0.0-SNAPSHOT versioning, this would break the build/deploy and possibly be a security issue also. An input flag should be used to initialize, by default the existence of the file should trigger failure, for a workflow/branch that expects a release version then a regex can be provided that the version contained in the .mvn/maven.config must match, in this case if the file does not exist it should error
A check should also be added to the pre-commit script in core-web/.husky/pre-commit so a user can be notified that the .mvn/maven.config is in the git index and should not before commit will work. A user should never commit this file to any branch directly. Make sure this logic is not running in CICD though that would prevent the promote step from working.
The text was updated successfully, but these errors were encountered: