-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry: processing upon API request interception needs to happen asynchronously #28531
Labels
Comments
dsilvam
changed the title
Telemetry: API request interception needs to happen asynchronously
Telemetry: processing upon API request interception needs to happen asynchronously
May 10, 2024
No changes are needed because saving the hit to the database is already done asynchronously, as shown here: We have some code that does not run on the request thread. This code selects the MetricType for the current request, which should not take much time. Additionally, if any exceptions are thrown in this code, the response will continue normally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parent Issue
No response
Problem Statement
When API interception is enabled, the processing is happening in a synchronous way which makes the requests to take longer and may even fail to respond if an underlying error happens.
Steps to Reproduce
Issue: see how the breakpoint gets hit but the page doesn't get rendered until resuming.
Acceptance Criteria
The processing that happens on the interception of the API hits needs to happen asynchronously.
dotCMS Version
Telemetry plugin 24.05.2
Proposed Objective
Core Features
Proposed Priority
Priority 2 - Important
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Quality Assurance Notes & Workarounds
No response
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered: