Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prompt=login outside of an oidc request #120

Open
jeffsawatzky opened this issue Jun 9, 2020 · 1 comment
Open

Use prompt=login outside of an oidc request #120

jeffsawatzky opened this issue Jun 9, 2020 · 1 comment

Comments

@jeffsawatzky
Copy link

The prompt=login etc is a nice feature to have even for non OIDC requests. Is there a reason why you restrict it to OIDC requests only?

@toupeira
Copy link
Member

toupeira commented Jul 6, 2020

@jeffsawatzky well mainly because this gem is hooking into Doorkeeper internals and tries its best not to interfere with non-OIDC requests 😉

I would be fine with a PR to add a configuration option for this though, I don't think any of the prompt values depend on an actual OIDC request so we could have just one flag to enable all prompt parameter handling for non-OIDC requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants