Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.dots bootstrap should use the local directory instead of downloading from github #39

Open
dportabella opened this issue Aug 11, 2016 · 0 comments

Comments

@dportabella
Copy link
Contributor

.dots contains the following:

        if [ $ARG == "bootstrap" ] || [ $ARG == "all" ]; then
            cd ~ && curl -#L https://github.com/donnemartin/dev-setup/tarball/master | tar -xzv --strip-components 1 --exclude={README.md,LICENSE}

I use this scenario:

$ git clone https://github.com/donnemartin/dev-setup.git
$ cd dev-setup
$ git checkout david  
# personalise my dev-setup, remove some stuff from brew.sh, add something else...
$ git commit -a -m "my personalized dev-setup"
$ ./.dots all

here I would expect to execute my personalized setup, as I am executing the setup from my ~/dev-setup directory. Instead, .dots downloads the scripts again from your github repo.
this does not make sense to me. If that's the behaviour you want, then you should provide a .dots file separately from this repo. If I execute the script from my ~/dev-setup directory, I expect all the installation scripts in that directory to be used, not only the .dots script.

also, the script copies all .dot files to the home directory. that makes sense. but it also copies all the installation scripts, and executes them from there. i think it would be better to execute the scripts from the dev-setup directory. once the installation is done, I want to have all .dot files in the home directory, but not the installation scripts. Also, the main script could be named differently, for instance setup.sh instead of .dots (I guess that at the beginning .dots was only copying .dot files and later you also installed programs, but now the script name is misleading).

did you plan to make such changes or it is not in line with your idea?
do you want me to make a pull request on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants