Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to Configure maxHandshakeRequests as an option to Postmate constructor #240

Open
Drew-Daniels opened this issue Apr 26, 2023 · 0 comments

Comments

@Drew-Daniels
Copy link

Drew-Daniels commented Apr 26, 2023

What Is the issue?

I would like for the ability to configure the maximum number of handshake requests the Parent window sends to the child - as the default of 5 seems to introduce some unnecessary rigidity.

Provide issue context below using code examples, images, or links


For my use case, I have two React apps, where, the embedded iFrame React app takes a few seconds to render, and once it has finished rendering, the parent React app has already sent all 5 handshake requests, and stops sending any more requests.

It would be nice, if for scenarios like mine, I would be able to override the default of 5 when I instantiate the Postmate object in the Parent window:

const handshake = new Postmate({
  container: document.getElementById('iframe-container'),
  url: IFRAME_URL,
  name: 'embedded-iframe',
  classListArray: ['embedded-iframe'],
  maxHandshakeRequests: 20,
})

Read about references issues here. Provide paragraph text responses to each header.

@Drew-Daniels Drew-Daniels changed the title [Feature Request] Ability to Configure maxAttempts as an option to Postmate constructor [Feature Request] Ability to Configure maxHandshakeRequests as an option to Postmate constructor Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant