Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxHandshakeRequests is not configurable #195

Open
marlon-tucker opened this issue Jan 20, 2020 · 0 comments
Open

maxHandshakeRequests is not configurable #195

marlon-tucker opened this issue Jan 20, 2020 · 0 comments

Comments

@marlon-tucker
Copy link

What Is the issue?

maxHandshakeRequests is defined internally and can't be configured.

Provide issue context below using code examples, images, or links

export const maxHandshakeRequests = 5

Having this be configurable, either by setting a static global variable (similar to debug) or passing a config option object into the Postmate constructor would enable us to accommodate IE11 being too slow to respond to the handshake in time. If this happens Postmate fails silently.

There is a pending PR which also fixes this by rejecting the handshake promise if this occurs, but having the maxHandshakeRequests be configurable would also be a way to adjust this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant