Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build "empty" nginx config when there are no web processes #6760

Open
josegonzalez opened this issue Mar 24, 2024 · 0 comments
Open

Build "empty" nginx config when there are no web processes #6760

josegonzalez opened this issue Mar 24, 2024 · 0 comments

Comments

@josegonzalez
Copy link
Member

Description of feature

Currently, if a user creates an app and any of the following are true:

  • either doesn't deploy it
  • there are no web processes specified in the Procfile
  • there are no running web processes (after a docker restart or similar)

What we should do is create a dummy nginx.conf that null-routes and only shows an error page for users. This way there isn't any ambiguity as to whether the app is created property or not.

Source for this is a conversation in slack where a user created an app and added letsencrypt, but then it wasn't resolving because we don't create a dummy nginx config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant