-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add getWrappedDriver method to AbstractDriverMiddleware #6308
Comments
And which cases would that be? The middleware stacks are not designed to be unwrapped and that's kind of on purpose.
Please be aware that So, even if we did add such a method to I don't know what problem you are trying to solve, but I would kindly ask you to find a different way. |
Case is mentioned here DamienHarper/auditor#184 and https://github.com/DamienHarper/auditor/blob/8edca5bedfda2f838003471321c60c45d941ba03/src/Provider/Doctrine/Auditing/Event/DoctrineSubscriber.php#L37-L42 this could be a wrong implementation from auditor lib, but it's OCP, we decorate connection/driver to add extra functionality - so imo valid solution to check instance if needed, but because driver/connection could be wrapped by many other decorators logic could be broken, that's why need to rewind or unwrap. |
Feature Request
There are cases when it's required to extact
$wrappedDriver
butAbstractDriverMiddleware
does not have such public api.DamienHarper/auditor#184
Summary
Adding get-method for
$wrappedDriver
The text was updated successfully, but these errors were encountered: