-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class-typed fields are required when inserting a new document #1851
Comments
oytuntez
changed the title
Typed fields are required when inserting a new document
Class-typed fields are required when inserting a new document
Feb 8, 2024
Hey @oytuntez , Can you please provide a code snippet of the code that showcases the problem, this turns out to be extremely helpful |
Thanks a lot, we are looking forward the PRs from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Initial Checks
Description
I have this dataclass:
When indexing a new document,
extracted_data
is always required no matter what I do (type it withOptional
etc). This is especially caused byBaseDocIndex._get_values_by_column()
.I have finally forked
docarray
, will send a PR for various minor fixes like this one:You can see my changes here, the highlighted line returns None when the field object is optional and not given for a new document during indexing.
Example Code
No response
Python, DocArray & OS Version
Affected Components
The text was updated successfully, but these errors were encountered: