Why does getJava exists with 1 and not 0?

[obfischer]

I am working on on automated installation of docToolchain during the build of a container for our pipelines.

While working on this, I stumbled about the option to install Java via dtcw. Why does the code to fetch Java exits with 1 instead of 0?

if [ "${1}" == "getJava" ]; then
    version=11
    implementation=hotspot
    heapsize=normal
    imagetype=jdk
    releasetype=ga
    case "${arch}" in
    x86_64) arch=x64 ;;
    arm64) arch=aarch64 ;;
    esac
    if [[ ${os} == MINGW* ]]; then
        echo ""
        echo "Error: MINGW64 is not supported"
        echo "please use powershell or wsl"
        exit 1
    fi
    case "${os}" in
    Linux) os=linux ;;
    Darwin) os=mac ;;
    Cygwin) os=linux ;;
    esac
    echo "this script assumes that you have linux as operating system (${arch} / ${os})"
    echo "it now tries to install Java for you"
    mkdir -p "${HOME}/.doctoolchain/jdk"
    echo "downloading JDK Temurin 11 from Adoptium to ${HOME}/.doctoolchain/jdk.tar.gz"
    download "https://api.adoptium.net/v3/binary/latest/${version}/${releasetype}/${os}/${arch}/${imagetype}/${implementation}/${heapsize}/eclipse?project=jdk" "${HOME}/.doctoolchain/jdk/jdk.tar.gz"
    #wget -r -O ${HOME}/.doctoolchain/jdk/jdk.tar.gz https://api.adoptium.net/v3/binary/latest/${version}/${releasetype}/${os}/${arch}/${imagetype}/${implementation}/${heapsize}/eclipse?project=jdk
    echo "expanding JDK"
    tar -zxf "${HOME}/.doctoolchain/jdk/jdk.tar.gz" --strip 1 -C "${HOME}/.doctoolchain/jdk/."
    rm -f "${HOME}/.doctoolchain/jdk.tar.gz"
    shift
    exit 1
fi

[rdmueller]

I think this is the bug why you have to execute
./dtcw local getJava
Instead of just
./dtcw getJava

I think it makes sense to fix this, but we are also already working on a new version.

So, quick workaround should be to user 'local' as first parameter...

[obfischer]

I will try it.

[obfischer]

Returns also 1. So I have to use RUN ./dtcw local getJava || true in my Dockerfile.

[mh182]

This is fixed with release 3.0 which hopefully will be released soon.