You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AAAARecord.getAddress() should return Inet6Address
I tried to change the return type (adding casts inside the method), but then I got
Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.14.0:cmp (check-compatibility) on project dnsjava: Versions of archives indicate a minor change but binary incompatible changes found.
While this changes the public API, usages of those methods should work like before, as the new return types can still be assigned to InetAddress. What could fail with this change is overriding those methods. Maybe the methods or the classes should be final.
The text was updated successfully, but these errors were encountered:
Unfortunately apicmp is right. While the change is source compatible, it isn't binary compatible and would result in java.lang.NoSuchMethodError: org.xbill.DNS.ARecord.getAddress()Ljava/net/InetAddress.
I'll stick to semver for this project, so I will consider this for the next major version.
To avoid having to cast in client code,
ARecord.getAddress()
should returnInet4Address
AAAARecord.getAddress()
should returnInet6Address
I tried to change the return type (adding casts inside the method), but then I got
While this changes the public API, usages of those methods should work like before, as the new return types can still be assigned to
InetAddress
. What could fail with this change is overriding those methods. Maybe the methods or the classes should be final.The text was updated successfully, but these errors were encountered: