Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Set SameSite and Secure property for authentication cookie #6039

Open
3 of 4 tasks
Mostafa-Moafi opened this issue May 16, 2024 · 0 comments · May be fixed by #6041
Open
3 of 4 tasks

[Enhancement]: Set SameSite and Secure property for authentication cookie #6039

Mostafa-Moafi opened this issue May 16, 2024 · 0 comments · May be fixed by #6041

Comments

@Mostafa-Moafi
Copy link
Contributor

Mostafa-Moafi commented May 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

  1. Defining SAMESITE to ensure that cookies are not sent to a third-party site or address. The value of this tag must be defined as "Strict".
  2. Definition of the SECURE tag to ensure that the cookie is transmitted through a secure communication path and that it cannot eavesdrop (the SECURE tag should be activated after activating the HTTPS protocol).

Description of solution

For the secure enabled, I think we should check SSL enabled in DNN and update the cookie when logging user.
for set SamaSite to Stric, we should just update the authentication cookie

Description of alternatives considered

No response

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant