Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Confirmation dialogs appear behind success dialogs #6009

Open
2 of 4 tasks
6TELOIV opened this issue Apr 3, 2024 · 0 comments
Open
2 of 4 tasks

[Enhancement]: Confirmation dialogs appear behind success dialogs #6009

6TELOIV opened this issue Apr 3, 2024 · 0 comments

Comments

@6TELOIV
Copy link

6TELOIV commented Apr 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

When deleting modules through Page Settings > Advanced > Modules, the confirmation dialog (i.e. would you like to delete this module? cancel/delete) pops up behind the dialog after a successful deletion. As there is no way to get rid of the success dialog, if you are trying to delete multiple modules quickly, you have to wait for the success dialog to disappear before being able to delete another.

Description of solution

I think there are many ways to fix this UI; a simple one would be change the z-index order so the confirmation dialog appears on top. Another one would be to change the confirmations to appear as a toast instead of a dialog, because they are non-interactive and only meant to convey information.

Another, different enhancement that would address this issue would be the ability to choose multiple modules for deletion at once.

Description of alternatives considered

N/A; the existing system works, but is inconvenient

Anything else?

Though I have not marked "Do you be plan to contribute code for this enhancement?", I would be willing to try contributing if someone could point me in the right direction on where this change would need to be made. I have never worked on DNN internals directly, so it would be a whole new world for me.

Also, there is a typo in the ticketing creation form of "Do you be plan to contribute code for this enhancement?". Should probably read as: "Do you plan to contribute code for this enhancement?"

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant