-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override formfield method on Brazilian Model Fields #489
Comments
It would be nice if you can provide a test that fails before your changes and passes afterwards (so that it would catch any future regression)! |
Thanks, @claudep ! |
Hello.
The Model Fields on Brazilian localflavor does not override the method
formfield
. By instance, the BRPostalCodeField is defined as:But in other countries this method was overrided. As instance, this is the Canadian PostalCode:
I made this change on Brazilian fields and it has passed all the tests. Do I need to write more tests or I can already submit a pull request?
The text was updated successfully, but these errors were encountered: