-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French local : Use class Validators for SIRET and SIREN model fields, do not format output #473
Comments
For the annoying formatting, I have found a workaround :
|
If you want to keep some arguments from the model, the workaround is more complicated (and ugly) :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
Right now the SIRET and SIREN model fields use SIRET and SIREN form fields that do the validation.
I prefer the architecture of the IBAN and BIC fields in generic that use class Validators,
since you can call the validators without using form fields.
Would you accept if I submit a PR with a new file validators.py in fr/
and add in it SIRENValidator and SIRETValidator classes ?
I would use them as is done for IBANValidator and BICValidator.
There is also an annoying thing :
SIRET is max length 14
but it is formatted with spaces.
Thus if in Django admin you modify a form with a valid SIRET in it you get this error :
"Ensure this value has at most 14 characters (it has 17)."
I don't know what is the nicest way to avoid this :
django-localflavor/localflavor/fr/forms.py
Lines 251 to 255 in 80c6584
Modifying a SIRET each time you submit a form because of this is an unvolontary "dark pattern" ;)
Thanks, best regards,
Laurent Lyaudet
The text was updated successfully, but these errors were encountered: