Money class instantiation returns Any as type

[alex-way]

When instantianting the djmoney.money.Money class it hints the type as Any when it should be Money. This prevents my code editor from presenting autocomplete suggestions as the type can't be inferred.

from djmoney.money import Money, DefaultMoney

i_am_any = Money(0) # is `Any`
i_am_money = DefaultMoney(0) # is `Money` class

[alex-way]

Digging into this further the issue is caused by the @deconstructable class decorator on the Money class in djmoney/money.py. This might point the issue more towards django, rather than this library. Will investigate further and report back, hopefully with a fix.

[antonagestam]

@alex-way Note that django-money does not yet expose type hints. py-moneyed received support for type hints in v2.0 and support for that was only recently merged: #638

Because that is now merged, there should be no blockers to adding type hints and exposing them with the py.typed marker.

It sounds like an interesting find with the deconstructable decorator. Does django-stubs have proper typing for it? E.g. should be something like (C) -> C.

[antonagestam]

Btw, unlocking the possibility to add type hints was the entire point of me pushing for the py-moneyed 2.0 upgrade here ;)

[alex-way]

As a workaround I've done something which I don't advise as it can cause issues with type hinting for other objects. However, it seems to work for my use case.

I created a file in the root of my repo typings/django/utils/deconstruct.pyi with the following file contents:

from typing import Any, Optional, Type
from djmoney.money import Money


# override for typehint
def deconstructible(*args: Any, path: Optional[Any] = ...) -> Type[Money]: ...

Again I'm not advocating for this solution, but just putting it out there for others who need a quick fix.

[karolyi]

I just opened a merge request for this exact problem: typeddjango/django-stubs#1116