Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DF-428] make user properties collapsible in template view #621

Closed
chandlercraig opened this issue Feb 1, 2024 · 11 comments · May be fixed by #648
Closed

[DF-428] make user properties collapsible in template view #621

chandlercraig opened this issue Feb 1, 2024 · 11 comments · May be fixed by #648

Comments

@chandlercraig
Copy link
Member

chandlercraig commented Feb 1, 2024

When user properties section is collapsed, text editor should expand left:

image

Collapse icon should be double left arrows inside of a circle, overlayed on the user properties section's right border (near the top), with a short, informative tooltip:

https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Akeyboard_double_arrow_left%3A

image

Expand icon should be double right arrows inside of a circle, overlayed on the border between the message editor and the Dittofeed menu bar, with a short, informative tooltip:

https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Akeyboard_double_arrow_right%3A

image

"Publish Changes" and "Send Test Message" buttons should appear as the following icons respectively, also inside of circles, overlayed on the same border as the expand icon (vertically, below expand button), with short, informative tooltips:

  1. Publish Changes https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Apublish%3A
  2. Send Test Message https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Aforward_to_inbox%3A

From SyncLinear.com | DF-428

@Kacppian
Copy link
Contributor

Kacppian commented Feb 2, 2024

I can take up this and #620 since they're both similar areas of work? I'll obviously submit 2 different prs though

@chandlercraig
Copy link
Member Author

Sounds good, thanks Kaushik! Let me know if you have any questions.

@chandlercraig
Copy link
Member Author

/bounty $20

@melsonic
Copy link

melsonic commented Feb 3, 2024

sorry I didn't see @Kacppian is already working on this

@KrishavRajSingh
Copy link

I would like to work on this

@chandlercraig
Copy link
Member Author

I would like to work on this

Hi Krishav, @Kacppian is working on it currently. He has 3 more days to submit a PR, otherwise I'll unassign the issue.

@Kacppian
Copy link
Contributor

Kacppian commented Feb 9, 2024

I will be submitting the PR today. Sorry for the delay, had a pretty rough week

@vinfinity7
Copy link

@chandlercraig whats up with this ?

@maxgurewitz
Copy link
Member

@vinfinity7, @Kacppian is busy so if you want to pick up from where he left off
#648
that'd be amazing 🙏

@vinfinity7
Copy link

ohk @maxgurewitz , ill get into this rightaway

@maxgurewitz
Copy link
Member

closed here #621

@algora-pbc algora-pbc bot removed the 💎 Bounty label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants