feat(User): add avatarDecorationData
#9888
Open
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almeidx
requested review from
ckohen,
vladfrangu,
iCrawl,
kyranet,
didinele,
Jiralite and
SpaceEEC
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9888 +/- ##
===========================================
- Coverage 95.89% 41.21% -54.69%
===========================================
Files 44 48 +4
Lines 3634 8897 +5263
Branches 283 267 -16
===========================================
+ Hits 3485 3667 +182
- Misses 149 5227 +5078
- Partials 0 3 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
almeidx
force-pushed
the
discord.js/avatar-decoration-presets
branch
from
90c1fc3
to
88e85b6
Compare
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-discordjs-avatar-decorati-739fa9-discordjs.vercel.app/ |
vladfrangu
approved these changes
Oct 17, 2023
didinele
approved these changes
Oct 18, 2023
ckohen
reviewed
Oct 18, 2023
ckohen
approved these changes
Oct 19, 2023
sdanialraza
reviewed
Oct 22, 2023
almeidx
force-pushed
the
discord.js/avatar-decoration-presets
branch
from
79bbcd1
to
1e1c732
Compare
almeidx
force-pushed
the
discord.js/avatar-decoration-presets
branch
from
1e1c732
to
a4417d7
Compare
|
In discord.js, should this be checked for in |
kyranet
approved these changes
Dec 24, 2023
Jiralite
reviewed
May 15, 2024
| @@ -3317,7 +3322,9 @@ export class User extends Base { | |||
|
|
|||
| public accentColor: number | null | undefined; | |||
| public avatar: string | null; | |||
| /** @deprecated Use {@link avatarDecorationData} instead */ | |||
There was a problem hiding this comment.
Suggested change
| /** @deprecated Use {@link avatarDecorationData} instead */ | |
| /** @deprecated Use {@link User.avatarDecorationData} instead */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Upstream:
Status and versioning classification: