Expose a WAV Buffer function #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seofernando25
commented
Apr 12, 2024
discordier
requested changes
Apr 12, 2024
|
I've updated the types to the ones you requested. |
discordier
approved these changes
Jun 10, 2024
discordier
added a commit
that referenced
this pull request
Jun 11, 2024
Feature release 0.3.0 Features: - New method `SamJs.wav(text: string, phonetic?: boolean): Uint8Array;` which renders a wave buffer. See #46, #47 (thanks to @seofernando25) Fixes: - Typo `dipthong` has been corrected to `diphthong` all over the code base. This includes the flag `FLAG_DIPTHONG` which is now named `FLAG_DIPHTHONG`. Fixes #19 - Fix comments to clearify that the '*' is not a wildcard but a marker that the second char in a phoneme is to be ignored. Fixes # 21 Additionally minor changes like adding download in demo html file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Changes:
RenderBufferto expose aToWavBufferfunction