Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo: Dipthong #19

Closed
dcuny opened this issue Jan 22, 2021 · 0 comments
Closed

Typo: Dipthong #19

dcuny opened this issue Jan 22, 2021 · 0 comments

Comments

@dcuny
Copy link

dcuny commented Jan 22, 2021

"Dipthong" is actually spelled "diphthong". The typo is all over the code.
discordier added a commit that referenced this issue Jun 11, 2024
@discordier
Merge tag '0.3.0'
5eb6e56 
Feature release 0.3.0

Features:
- New method `SamJs.wav(text: string, phonetic?: boolean): Uint8Array;`
which
  renders a wave buffer.
  See #46, #47 (thanks to @seofernando25)

Fixes:
- Typo `dipthong` has been corrected to `diphthong` all over the code
base.
This includes the flag `FLAG_DIPTHONG` which is now named
`FLAG_DIPHTHONG`.
  Fixes #19
- Fix comments to clearify that the '*' is not a wildcard but a marker
that the
  second char in a phoneme is to be ignored.
  Fixes # 21

Additionally minor changes like adding download in demo html file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcuny