-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: BaseSocketClient and DiscordRestClient do not properly implement [Feature] Premium Subscriptions #2808
Comments
Maybe I could make a source analyzer/generator for this? |
cc @quinchs |
@Panthr75 there's no need to override these interface members. _ = await interfaceClient.GetSKUsAsync(); will actually call the method implementation from You an easily verify it by placing breakpoints in |
Removing the |
Check The Docs
Verify Issue Source
Check your intents
Description
DiscordRestClient
andBaseSocketClient
were modified to include the interface implementation override for memberTask<IEntitlement> IDiscordClient.CreateTestEntitlementAsync(ulong, ulong, SubscriptionOwnerType, RequestOptions?)
, but not for:Task IDiscordClient.DeleteTestEntitlementAsync(ulong, RequestOptions?)
IAsyncEnumerable<IReadOnlyCollection<IEntitlement>> IDiscordClient.GetEntitlementsAsync(int?, ulong?, ulong?, bool, ulong?, ulong?, ulong[]?, RequestOptions?)
Task<IReadOnlyCollection<SKU>> IDiscordClient.GetSKUsAsync(RequestOptions?)
This means that when using an object of type
IDiscordClient
and calling one of those non-overriden members, you will get unexpected behaviour, as it will use the implementation insideBaseDiscordClient
which returnsnull
pretty much.This isn't the first time this has happened: 8baf913
Maybe some automated tooling needs to be put into place so that
BaseSocketClient
andDiscordRestClient
properly override the defaultBaseDiscordClient
implementation, or a reconsideration of how these classes are structured may need to take place.Version
3.13.0
Working Version
3.12.0
Logs
Sample
Packages
N/A
Environment
N/A
The text was updated successfully, but these errors were encountered: