Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotation marks not working on iOS #79

Open
JcbSm opened this issue Sep 17, 2019 · 7 comments · May be fixed by #112
Open

Quotation marks not working on iOS #79

JcbSm opened this issue Sep 17, 2019 · 7 comments · May be fixed by #112
Labels
bug

Comments

@JcbSm
Copy link

JcbSm commented Sep 17, 2019 •
edited

When using the split: "quoted" option, the quotation marks which are used on iOS (maybe other devices, I'm not sure) aren't recognised as quotation marks.

When command is done from iPhone:
image

When done from Desktop app:
image

Thanks :D
@Aeryle
Copy link
Contributor

Aeryle commented Sep 17, 2019

This is expected behavior, iOS' quotes are another Unicode than the one on Android, Windows and some other OS, so it's totally normal, just use normal quotes, and not iOS' one. Or make a PR to make it accept this Unicode character too.

@GamesProSeif
Copy link
Contributor

GamesProSeif commented Sep 17, 2019 •
edited

Just for reference to show difference and if you're going to make a PR or anything.

normal quote:
  name: QUOTATION MARK
  symbol: \"
  unicode: \u0022
left quote:
  name: LEFT DOUBLE QUOTATION MARK
  symbol: “
  unicode: \u201C
right quote:
  name: RIGHT DOUBLE QUOTATION MARK
  symbol: ”
  unicode: \u201D

@lhayhurst
Copy link

I've noticed this is true for hypens as well.

@gazmull
Copy link
Contributor

gazmull commented Sep 20, 2019

I've noticed this is true for hypens as well.

It's different from the minus sign - commonly/easily typed with desktop keyboards. You should watch out for that (check this for reference).

@D3rise
Copy link

D3rise commented Apr 8, 2020

Any update on this?

@papaia
Copy link
Contributor

papaia commented Apr 8, 2020 •
edited

Wasn't this implemented?
ContentParser looks like it has support for them.

Well, after checking it with some changes, turns out some checks are wrong, and when fixing them, this happens
image

@papaia
Copy link
Contributor

papaia commented Apr 8, 2020 •
edited

Managed to fix, expect a PR soon 🎉.

Just 2 hours, not bad 😆!

This was referenced Apr 8, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
8 participants
@lhayhurst @1Computer1 @gazmull @D3rise @papaia @GamesProSeif @Aeryle @JcbSm