Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart failed workflows #687

Open
jensg-st opened this issue Oct 18, 2022 · 1 comment
Open

Restart failed workflows #687

jensg-st opened this issue Oct 18, 2022 · 1 comment
Labels
improvement New feature or request
Milestone

Comments

@jensg-st
Copy link
Member

Is your feature request related to a problem? Please describe.

At the moment a failed workflow is a failed workflow. When it is failed we still have the state data and we could potentially re-run it. If it is script-based e.g python, node etc., the script could be fixed and the workflow could restart from there. Of course the workflow can not be changed but the supporting data like variables or in 0.8.0 files / scripts from git.

@alankm
Copy link
Member

alankm commented Oct 18, 2022

Restart from there? As-in, restart part-way through the workflow? This may be harder than it looks. Or very limited in capability. Yes, I think we could replay an instance from its final state. But what about workflows that did some attempts at error handling? How many states back do we need to go? Intermediate state data isn't saved, so anything other than the very last state is currently not possible. There's a lot of nonsensical states to resume to as well: what if the last state was an event listener? I also think this would cause strange behaviour in things like tracing and metrics.

The instance input data is available as long as the record of the instance hasn't been deleted. And it's available by the API. The frontend shows it. It seems far simpler and safer to have a button on the failed instance screen that retriggers the workflow using the same input data. This could be made to work with changed workflows.

@jensg-st jensg-st added the improvement New feature or request label Oct 19, 2022
@jensg-st jensg-st added this to the 0.9.0 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants