-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s390x test workflow #3065
Add s390x test workflow #3065
Conversation
Hi @viusic, Thank you for doing this. After a quick look, It looks like a good beginning but it is missing DIPY installation and test. |
Hi @skoudoro, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @viusic,
Thank you for your update. See some comments below.
|
||
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the checkout version
run: | | ||
sudo debootstrap --arch s390x sid /srv/chroot/sid-390x http://ftp.fr.debian.org/debian | ||
|
||
- name: Install Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to install the dependencies, you will have to use what you just checkout above
sudo chroot /srv/chroot/sid-390x apt-get install -y python3 python3-pip | ||
sudo chroot /srv/chroot/sid-390x pip3 install cython numpy==1.22.4 scipy==1.8 nibabel==3.0.0 h5py==3.1.0 tqdm | ||
|
||
- name: Install DIPY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to install dIPY, you will have to use what you just checkout above
- name: Run Compatibility Tests | ||
run: | | ||
sudo chroot /srv/chroot/sid-390x python3 -m dipy.test -k compat | ||
|
||
- name: Run Optional Tests | ||
run: | | ||
sudo chroot /srv/chroot/sid-390x python3 -m dipy.test -k optional | ||
|
||
- name: Run Parallel Tests | ||
run: | | ||
sudo chroot /srv/chroot/sid-390x python3 -m dipy.test -k parallel | ||
|
||
- name: Run Pre Tests | ||
run: | | ||
sudo chroot /srv/chroot/sid-390x python3 -m dipy.test -k pre | ||
|
||
- name: Run Template Tests | ||
run: | | ||
sudo chroot /srv/chroot/sid-390x python3 -m dipy.test -k template | ||
|
||
- name: Run Visualization Tests | ||
run: | | ||
sudo chroot /srv/chroot/sid-390x python3 -m dipy.test -k viz | ||
|
||
- name: Run General Tests | ||
run: | | ||
sudo chroot /srv/chroot/sid-390x python3 -m dipy.test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure this syntax work for DIPY. Can you check it locally
Hi @viusic, Do you have an update on this? thank you for your future feedback |
hi @skoudoro,
I have designed it to run on a self-hosted runner, which means it can be run on any machine that meets the required hardware and software specifications. The workflow is also configured to run on a matrix of different architectures, including s390x.
During this time, I've been investing some of my efforts in crafting a proposal for GSoC'24, specifically within our organization. Exploring the intricacies of DIPY while contributing has only deepened my interest in the project. I believe this investment will not only contribute positively to the proposal but also enhance my understanding of DIPY, making me more effective in my contributions. I am currently fine-tuning the syntax for running test suites and conducting local tests to ensure everything is set up correctly. I anticipate resolving any remaining issues by tomorrow. I appreciate your understanding and patience during this process. If you have any specific guidance or suggestions, please feel free to share them. Thank you for your support. |
What does it means ?
ok
See my review above For now, I will close this PR. Feel free to reopen it when it is ready and you succeed to finalize the remaining issues. Thank you again for working on this. |
Pull Request Summary
This pull request adds a s390x test workflow to address issue #3044.
Purpose
The purpose of this change is to enable testing on the s390x architecture using QEMU and Debian.
Details of Changes
.github/workflows/s390x_test.yml
for s390x testing.Issues Resolved
Closes #3044
Request for Review
I appreciate your time in reviewing this pull request. Please let me know if there are any suggested improvements or changes.