Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections of base types won't scrub #14

Open
dills122 opened this issue Mar 23, 2019 · 2 comments
Open

Collections of base types won't scrub #14

dills122 opened this issue Mar 23, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@dills122
Copy link
Owner

If using an IEnumerable or List of base types (string, int,, double, etc) it will not scrub.

The issue is related to how collections are decomposed for scrubbing. They are treated as classes and a new scrubber engine is spawned, which isn't meant to handle a base type as a direct input.

@dills122 dills122 added the bug Something isn't working label Mar 23, 2019
@dills122
Copy link
Owner Author

Investigation so far:

  • Will require a rework of ScrubListItems method to have a check and separate routing for base types.
  • Will require an overload of ScrubProperty to not have a property (since a base type of a collection wouldn't be a property, but an object in this case)
  • will require a rework of ManifestBuilder since it relies on a property and in this case you wouldn't have one available

@dills122
Copy link
Owner Author

PR 15 Initial start to fixing issue.

Small change dealing with the changing of the property variable in ManifestInfo POCO from type PropertyInfo to string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant