-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined method sync for #121
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! Thanks for all the hard work being put into the Polyphony gem!
We found an issue when using the gem in some code that interacts with a MySQL database through Sequel.
We have required both
polyphony/adapters/sequel
andpolyphony/adapters/mysql
. The error is the following:When looking at the stack trace of the error;
We can see that the
connection_validator
from Squel is making the following call;Where
pool
is an instance ofPolyphony::FiberConnectionPool
. The problem is that this class does not implement thesync
method and fails. The originalsync
is just doing ayield
inside amutex
, so we did a simple patch on this class by adding the method asAnd it seemed to solve the issue alright. Since we don't really know the implications of this, we were hesitant to open a PR.
Some environment details:
polyphony version:
1.6
ruby version:
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin21]
Uname
Darwin 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:20:05 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T8101 arm64
The text was updated successfully, but these errors were encountered: