Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation Error Handling Levels #1520

Open
Tracked by #1527
anthony-chaudhary opened this issue Aug 14, 2023 · 0 comments
Open
Tracked by #1527

Annotation Error Handling Levels #1520

anthony-chaudhary opened this issue Aug 14, 2023 · 0 comments

Comments

@anthony-chaudhary
Copy link
Member

anthony-chaudhary commented Aug 14, 2023

We need more clear error handling components and framing for the various panels and levels of file loading.
Generally what I am picturing is three "unavoidable" levels

  • Parent file level
  • Panel/Child file level
  • Media specific level

With the assumption that the errors should be handled in that hierarchal order.

  • e.g. A child panel should not care about other child file errors
  • An error that's at the child file level should not be handled by a media specific UI
  • A media specific error should not be handled by the child file

Goals are

  • Clarifying where errors get added in the higher level component vs per-panel errors etc.
  • Organizing the error components better, e.g having a single error component for all "top level" errors at each level

Current state, for example this was duplicated on the lower level component

    <div v-else-if="interface_type === 'compound' && annotation_ui_context.working_file_list.length === 0 && !initializing" >
      <empty_file_editor_placeholder
        :message="'Try adding child files to this compound file.'"
        :title="'This compound file has no child files.'" />
    </div>

07b05bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant