Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to reset overlays on page? #2423

Open
jackhagley opened this issue Oct 14, 2023 · 8 comments
Open

How to reset overlays on page? #2423

jackhagley opened this issue Oct 14, 2023 · 8 comments

Comments

@jackhagley
Copy link

ISSUE

I create an overlay, but it accidentally hides elements that I want

WORKAROUND

turn off Ad Nauseam on page entirely
This is not ideal

PROPOSED SOLUTION

Button in the dropdown menu "Reset overlays on this page" to return it to pre-blocked state

@mneunomne
Copy link
Collaborator

@jackhagley what exactly you mean by overlay? a cosmetic filter?

@jackhagley
Copy link
Author

jackhagley commented Oct 15, 2023 via email

@mneunomne
Copy link
Collaborator

I'm not sure if there is a good way to implement this. Because sometimes you could have added a cosmetic rule that is not domain-specific. on the uBlock menu you can disable the cosmetic filters on the current page. But I think the best way to reverse this is to simply delete the filters that were added in the "My Filters" tab in the dashboard.

@dhowe
Copy link
Owner

dhowe commented Oct 19, 2023

Seems the simplest answer would be to 'use the uBlock menu and disable the cosmetic filters on the current page', yes ?

If this is a solution, we could then discuss whether it makes sense to add a button...

@mneunomne
Copy link
Collaborator

I don't think it makes sense to add a button in this case. to have an UI button knowing there is a current filter in "my filters" matching the current domain string would require some unnecessary computing and de-compiling the 1p-filter just for 1 small feature.

@jackhagley
Copy link
Author

jackhagley commented Oct 23, 2023 via email

@mneunomne
Copy link
Collaborator

Sorry @jackhagley I didn't mean it's an unnecessary feature, but an additional computing of filters on every page-load can be costly.

@jackhagley
Copy link
Author

jackhagley commented Oct 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants