Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternate rendering backends #98

Open
dhleong opened this issue Jan 1, 2020 · 1 comment
Open

Consider alternate rendering backends #98

dhleong opened this issue Jan 1, 2020 · 1 comment

Comments

@dhleong
Copy link
Owner

dhleong commented Jan 1, 2020

JLine still doesn't actually support 24-bit true color (in fact, its conversion from RGB ANSI to their internal AttributedStyle seems broken—it's what our conversion from FlavorableCharSequence to their AttributedString for rendering is based on, and the results (from a branch for #90) are garbage:

Screen Shot 2020-01-01 at 6 46 26 PM

vs this, using their Colors.roundRgbColor:

Screen Shot 2020-01-01 at 6 47 59 PM

Laterna, for example, has classes to support RGB color, but it's unclear whether their abstraction will round down on terminals that don't support it....

@dhleong
Copy link
Owner Author

dhleong commented Jul 18, 2020

Just did an experiment and Lanterna does not automatically round down RGB to a supported color, so we'd need a translation layer that can respect the terminal's capabilities....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant