Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support binding the Mapper to a specific buffer/window #73

Closed
dhleong opened this issue Jan 23, 2019 · 0 comments
Closed

Support binding the Mapper to a specific buffer/window #73

dhleong opened this issue Jan 23, 2019 · 0 comments
Assignees
@dhleong
Labels
feature

Comments

@dhleong
Copy link
Owner

dhleong commented Jan 23, 2019 •
edited

Right now it looks like it basically just writes to the "current" window, which is not ideal. Especially with the upcoming vsplit support (#71) it'd be nice to be able to create a split and only render into that window/buffer.
dhleong added a commit that referenced this issue Feb 20, 2019
@dhleong
Refactor MapManager to render to a specific Window
a00b0ca 
Refs #73

Rather than defaulting to whatever window is current, it selects
the "current" window on init (eg: createEmpty) and uses that forever
unless another window is specified.

If provided a non-primary Window, that window will be cleared before
the map is rendered into it.

Furthermore, we simplify the resize mechanics to match *the specific
window* we're rendering into.
@dhleong dhleong self-assigned this Feb 20, 2019
dhleong added a commit that referenced this issue Feb 20, 2019
@dhleong
Expose judo.mapper.window to scripting
83b4bb6 
Closes #73

This commit also renames the internal IJudoWindow.onSubmit to
`onSubmitFn`.  It's a little annoying, but it allows a simple
implementation of onSubmit for `IScriptWindow` that doesn't conflict
with `IJudoWindow`, so implementations of `IScriptWindow` can also
implement `IJudoWindow` for greater interop.
@dhleong dhleong mentioned this issue Feb 20, 2019
Merged
dhleong added a commit that referenced this issue Feb 20, 2019
@dhleong
Support binding the Mapper to a specific window (#82)
ea6524f 
* Refactor MapManager to render to a specific Window

Refs #73

Rather than defaulting to whatever window is current, it selects
the "current" window on init (eg: createEmpty) and uses that forever
unless another window is specified.

If provided a non-primary Window, that window will be cleared before
the map is rendered into it.

Furthermore, we simplify the resize mechanics to match *the specific
window* we're rendering into.

* Expose `judo.mapper.window` to scripting

Closes #73

This commit also renames the internal IJudoWindow.onSubmit to
`onSubmitFn`.  It's a little annoying, but it allows a simple
implementation of onSubmit for `IScriptWindow` that doesn't conflict
with `IJudoWindow`, so implementations of `IScriptWindow` can also
implement `IJudoWindow` for greater interop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhleong dhleong

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhleong