Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ascii/Unicode switch support #6

Open
morucci opened this issue Aug 6, 2020 · 4 comments
Open

Ascii/Unicode switch support #6

morucci opened this issue Aug 6, 2020 · 4 comments

Comments

@morucci
Copy link

morucci commented Aug 6, 2020

Hi,

Not sure this is related to that piece but I'd like to be able to set the dhall plugin for vscode to use ascii only (to be consistent with the rest of the dhall projects my team is working on). Unfortunately, I don't see an option for that. Please let me know if this is supported and how to setup.

Thanks in advance for the help.
Fabien

@sjakobi
Copy link

sjakobi commented Aug 6, 2020

This sounds related to dhall-lang/dhall-haskell#1533.

But AFAIK the option was created for the other plugin: https://github.com/dhall-lang/vscode-dhall-lsp-server

Ping @EggBaconAndSpam.

@EggBaconAndSpam
Copy link

dhall-lang/dhall-haskell#1533 implemented the option on the server. Even though it is not exposed in the vscode-language-dhall options, you can still set "vcsode-dhall-lsp-server.asciiOnly": true in your settings.json to enable it. Have a look at the screen recording in the PR :)

@PanAeon
Copy link
Collaborator

PanAeon commented Aug 8, 2020

@EggBaconAndSpam does any changes required in the vscode plugin? I'm afraid I think I still own the plugin so only I can push it to the marketplace. I've got some time this days, so I suggest I create a new azure organization for dhall, add all contributors and generate CI keys. Then we can even setup github actions for publishing. This requires deleting old and publishing new plugin to the marketplace. I can't give you current keys, as they are for my personal account)
wdut?

@morucci
Copy link
Author

morucci commented Aug 10, 2020

@EggBaconAndSpam Hi thanks. I'm unable to get it worked. I notice the feature has been merged Nov 14 2019 but the plugin dhall-lsp-server 0.0.4 has been released the Aug 14 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants