Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] pip build tester didnt catch the error - but it showed the error #2239

Open
dgtlmoon opened this issue Mar 8, 2024 · 0 comments
Open

[build] pip build tester didnt catch the error - but it showed the error #2239

dgtlmoon opened this issue Mar 8, 2024 · 0 comments
Assignees
@dgtlmoon
Labels
bug Something isn't working

Comments

@dgtlmoon
Copy link
Owner

dgtlmoon commented Mar 8, 2024 •
edited

https://github.com/dgtlmoon/changedetection.io/actions/runs/8207172254/job/22447920870

the pip build tester correctly showed the error, but the step never failed

image

Looks like the app would still run, maybe the fix is have it run a testafter installing in a clean environment
@dgtlmoon dgtlmoon added the bug Something isn't working label Mar 8, 2024
@dgtlmoon dgtlmoon self-assigned this Mar 8, 2024
@dgtlmoon dgtlmoon changed the title pip build tester didnt catch the error - but it showed the error [build] pip build tester didnt catch the error - but it showed the error Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgtlmoon dgtlmoon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgtlmoon