Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] epic - remove playwright and use pyppeteer-ng directly #2237

Open
6 tasks
dgtlmoon opened this issue Mar 8, 2024 · 0 comments
Open
6 tasks

[feature] epic - remove playwright and use pyppeteer-ng directly #2237

dgtlmoon opened this issue Mar 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dgtlmoon
Copy link
Owner

dgtlmoon commented Mar 8, 2024

There is no reason to use playwright anymore now that https://github.com/dgtlmoon/pyppeteer-ng exists.

This library works "good enough" for our basic scraping/checking requirements. Now we can talk directly from Python/CDIO into the Chrome browser, no need for a middle "node" process (horrible!!)

It's important to remember that Playwright is written as a TESTING library first, it's not meant exactly for our use-case.

The main two drawbacks with playwright are

  • It spins up a very heavy node process for every watch PLUS the browser
  • Is a lot more platform dependant
  • Less code to maintain
  • pyppeteer-ng is async based (so is playwright, tho we use it in sync mode)
  • Way lighter docker builds
  • Faster checking

Problems - may impact robot-evasion abilities, we will see.

Todo

@dgtlmoon dgtlmoon added the enhancement New feature or request label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant