-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails for MSYS2 MinGW toolchain #692
Comments
The shipped fypp doesn't work on a clean Windows build due to missing Python installation. For Windows builds it is therefore always required to specify fypp by |
Found out that the |
Describe the bug
While trying to apply the MinGW64 toolchain from MSYS2 to a few projects I noticed DFTB+ does not work correctly in the MSYS2 bash shell.
To Reproduce
mingw-w64-x86_64-*
packagesfypp
withpip
(and set-DFYPP=$(which fypp)
in the CMake configuration step)and observe failure while preprocessing (see https://github.com/awvwgk/dftbplus/runs/1588112700)Linking fails with (see https://github.com/awvwgk/dftbplus/runs/1619199655#step:6:12351)Linking only works if
-DLAPACK_LIBRARY=...
is explicitly specified, otherwise the link line is not propagated in theCustomLapack
module:Testing might fail due to similar issues as with the fypp command not working
Expected behaviour
CMake shouldn't use the Windows CMD.exe but the MSYS2 (bash) shell to get the correctly setup environment.LAPACK should be linked correctly.Tests should be generated.
Additional Context
The preprocessing with
fypp
used in https://github.com/fortran-lang/stdlib works correctly with the MSYS2 MinGW64 toolchain and a similar workflow file.Just creating this issue to keep track of it. I might come up with a fix if I find time to look into this.
The text was updated successfully, but these errors were encountered: