-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan can never be applied because we always have different plans #254
Comments
I think you can have a manual approval of deployments if you use the Environments feature of GitHub. It's not something I've used. You can run the I use the PR itself as the approval gate. If something isn't ready to be deployed, it doesn't get merged. |
I have this same issue with ECS task definitions because the image is tagged with the short-sha. |
Problem description
Hello,
I am trying to use
terraform-apply
once the PR is merged indevelop
. I am getting the error below, because the two plan are different. The one generated in the PR saysPlan: 2 to add, 1 to change, 2 to destroy
, instead the one after the merge saysPlan: 5 to add, 2 to change, 5 to destroy
.This is kind of normal for us because when a deployment has to happen some variable change and then also the resource that will be modified. For example the git short sha will be attached to the docker image name and that will always make terraform generate a different plan.
I would prefer to run
apply
without-auto-approve
, I remember when I was working with Jenkins that we were receiving a notification in case of infrastructure changes, we could then review the plan and confirm it by clicking a link in the console.Is it possible to do something similar with GitHub actions too?
Thank you
Terraform version
1.3.7
Backend
s3
Workflow YAML
Workflow log
The text was updated successfully, but these errors were encountered: