Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested grids do not work #62

Open
thorinmesser opened this issue Sep 8, 2017 · 4 comments
Open

Nested grids do not work #62

thorinmesser opened this issue Sep 8, 2017 · 4 comments

Comments

@thorinmesser
Copy link

You can see this on the project home page, the nested grid example there does not work. I think due to line 193 of gridlex.scss where it sets every child of grid that isn't set to "0" to display block (I think), but the nested grid wants to be display flex.

@thorinmesser
Copy link
Author

So this is weird, suddenly they work for me in my project. Please ignore me.

@thorinmesser
Copy link
Author

Ok, don't ignore me. I was autoresponding and my local npm was using 2.4.0 as I have specified but my build server was using 2.4.1, and 2.4.1 does not work with nested grids as explained above.

@thorinmesser thorinmesser reopened this Sep 8, 2017
@davidchameleon
Copy link

I'm having the same issue- even when I use the examples from the Docs.

@leeoniya
Copy link

the odd thing is, this appears to be known problem which is accounted for by the commented code [1] which is pretty specific in saying "grids which aren't hidden by -0 for the given media query should be display: flex". i can't think of where this can ever cause undesirable behavior.

@devlint any reason why this remains off? 😕

[1]

gridlex/src/gridlex.scss

Lines 195 to 197 in ee4f7bb

&:not([#{$gl-attributeName}*="_#{$mq-key}-0"]) {
display: flex;
}*/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants