Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GitHub/fetch tests against this polyfill #2

Open
mohsen1 opened this issue Feb 22, 2017 · 3 comments
Open

Run GitHub/fetch tests against this polyfill #2

mohsen1 opened this issue Feb 22, 2017 · 3 comments

Comments

@mohsen1
Copy link

mohsen1 commented Feb 22, 2017

I did try putting together a PR that runs all tests at github/fetch but got overwhelmed by amount of work required. Basically it should be done via Git submodules and a shell/node script that swaps the implementation in the submodule with dist of this project.

Doing most of things manually I saw a few tests failing.

@developit
Copy link
Owner

Sound good. We will definitely need to selectively ignore some tests though.

@mohsen1
Copy link
Author

mohsen1 commented Feb 22, 2017

Which parts you think it should fail?

@developit
Copy link
Owner

developit commented Feb 22, 2017

unfetch intentionally doesn't recreate the Headers or Response classes, instead using POJO's for them to shave bytes (so those tests should all fail). The rest are just size tradeoffs - I was on the fence about even supporting Response#xml() and Response#blob(), but the size bump was minimal (10b) for them. To me, unfetch is best kept as a bare minimum feature set: loosely emulating the fetch() API semantics but allowing the same userland usage so that it remains transparent for the 99% case. Anything that falls under the umbrella seems like fair game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants