Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying PowerShell Module Version #963

Closed
russellds opened this issue May 8, 2024 · 3 comments · Fixed by #993
Closed

Support specifying PowerShell Module Version #963

russellds opened this issue May 8, 2024 · 3 comments · Fixed by #993
Assignees
Labels

Comments

@russellds
Copy link

It would be extremely helpful if you could specify the version of the PowerShell module(s) to be installed. There are times where I need a specific version, typically with the Azure PowerShell module, because of issues with the latest version.

A simple way to do it would be to seperate the module and version with a colon, see below. If the version is not specified, then install the latest as it currently works.

"ghcr.io/devcontainers/features/powershell:1": {
      "version": "latest",
      "modules": "powershell-yaml,Az:11.4.0"
    }
@samruddhikhandale
Copy link
Member

Hi 👋

The request makes sense to me and I like the suggested approach of using the : delimiter ; adding this item to the backlog!

@russellds if you are interested, feel free to open a PR with the proposed changes. We appreciate community contributions and I'm happy to help with the reviews 🙏

@prathameshzarkar9
Copy link
Contributor

Hi @samruddhikhandale ,

I have created the PR for this fix here: #993
kindly review and approve the same if it satisfies the user requirements

@samruddhikhandale samruddhikhandale linked a pull request Jun 3, 2024 that will close this issue
1 task
@prathameshzarkar9
Copy link
Contributor

Hi @samruddhikhandale ,

Addressed review comments on the PR and also added a test case to verify the specified Powershell module version is installed successfully.

samruddhikhandale added a commit that referenced this issue Jun 11, 2024
* #963 specific powershell module version install

* review comments addressed

* added test for the version specific module installation and addressed review comments

* Update src/powershell/install.sh

* Update src/powershell/install.sh

* Update src/powershell/install.sh

---------

Co-authored-by: Samruddhi Khandale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants