-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desire to have a way to list relevant (changed) features #197
Comments
Hi 👋 I didn't realize that the features-starter repos's test.yaml executes tests for all Features (instead of running test for the modified Feature code) The Feature's repo has been using I think we avoided adding @jcbhmr Looks like you are trying to suggest that we use https://github.com/devcontainers-community/list-features in the |
yeah that's pretty much it! 👍 |
idk if this is the right spot to bring this up but hey 🤷♀️
I've recently found immense usefulness in being able to list which features changed and default to all of them if the changes cant be determined https://github.com/devcontainers-community/list-features (no its not very polished yet)
i notice that there seems to be an attempt to do this in the feature-starter repo:
I think it's very nice to be able to do this instead:
or this if you prefer to matrix your image too (disclaimer haven't tested this flow yet)
used in a repo like this
https://github.com/devcontainers-community/npm-features/blob/main/.github/workflows/test-features.yml
demo of it in action![image](https://private-user-images.githubusercontent.com/61068799/261445118-bc2d7852-f62d-431f-ad4e-e68b3fe80f2e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg4NTI3NTIsIm5iZiI6MTcxODg1MjQ1MiwicGF0aCI6Ii82MTA2ODc5OS8yNjE0NDUxMTgtYmMyZDc4NTItZjYyZC00MzFmLWFkNGUtZTY4YjNmZTgwZjJlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIwVDAzMDA1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYxZGIzZTA2Y2Y0OGExYzEwN2IzNWRiYzhlYmUwYWRhMWFiN2VhYTA5YTZjYzk2NjUxYzgwYTFiNDcxZDA1YjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.6BpYc7YjKuNFqTet0RKcQ8ExITb06NrA6ULnBM15RFE)
https://github.com/devcontainers-community/npm-features
ex:
id to see this thing into the official @devcontainers feaeture-starter or organization if that's possible. idk if this is completely breaking some kind of unspoken project ettiqute; i just want this thing to be "official" since it seems so cool.
The text was updated successfully, but these errors were encountered: