Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Fullscreen #1444

Open
mishoboss opened this issue Apr 16, 2024 · 1 comment
Open

iOS Fullscreen #1444

mishoboss opened this issue Apr 16, 2024 · 1 comment

Comments

@mishoboss
Copy link

mishoboss commented Apr 16, 2024

I know iOS webview is not supporting the fullscreen API, but I'm thinking a custom JS implementation as a workaround - take the screen size, render a DIV with that size as an overlay and render the player inside that DIV.

What do you think about such an approach? Fullscreen on iOS is really missing.

@dermotduffy
Copy link
Owner

Not opposed to it, but reluctant to spend limited development cycles on adding support that the vendor themselves should add (and presumably have intentionally not added at this point?). More personally, I have no iOS device to test with. If you're a developer, and wanted to prepare a PR, more than happy to support/review!

I am thinking that the existing "expanded" mode (that pops the card into a dialog) could perhaps be modified into a "fake" fullscreen ... at least this is where I'd start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants