Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] more direct way to refresh daemon environment #541

Open
brandonbloom opened this issue Jan 3, 2022 · 3 comments
Open

[FEATURE] more direct way to refresh daemon environment #541

brandonbloom opened this issue Jan 3, 2022 · 3 comments
Labels
feature request Community feature request
Milestone

Comments

@brandonbloom
Copy link
Member

brandonbloom commented Jan 3, 2022

Right now, you have to do exo exit then restart the daemon to pickup any new environment variables at that level. It shouldn't be necessary to do this.

We may wish to explicitly invoke the user's preferred shell, so that we get a "clean" environment, instead of whatever environment exo happened to have been run in when it started the daemon.

@brandonbloom brandonbloom added feature request Community feature request needs triage Incoming request that needs to be triaged and prioritized labels Jan 3, 2022
@brandonbloom
Copy link
Member Author

cc @finnigantime

@brandonbloom brandonbloom removed the needs triage Incoming request that needs to be triaged and prioritized label Jan 3, 2022
@brandonbloom brandonbloom changed the title [FEATURE] more directly way to refresh daemon environment [FEATURE] more direct way to refresh daemon environment Feb 16, 2022
@brandonbloom
Copy link
Member Author

brandonbloom commented Feb 17, 2022

This will be fixed when #543 lands. See 82591c3.

brandonbloom added a commit to brandonbloom/exo that referenced this issue Feb 17, 2022
@brandonbloom
Copy link
Member Author

@stevekrenzel points out that the automatic environment refreshing logic means that something like FOO=123 exo start bar would not pass the FOO variable over to the bar program, which seems counter-intuitive. I think the new behavior of ignoring the ephemeral shell state is a better default, but definitely not ideal. Before closing this issue, we'll need to figure out if there is some way to handle/surface interactive environment differing from the default environment snapshot.

brandonbloom added a commit to brandonbloom/exo that referenced this issue Feb 17, 2022
@brandonbloom brandonbloom added this to the Overhaul milestone Feb 28, 2022
brandonbloom added a commit that referenced this issue May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Community feature request
Projects
None yet
Development

No branches or pull requests

1 participant