Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landmark-unique does not reflect latest HTML-role mappings #4460

Open
1 task done
gabalafou opened this issue May 14, 2024 · 2 comments · May be fixed by #4469
Open
1 task done

landmark-unique does not reflect latest HTML-role mappings #4460

gabalafou opened this issue May 14, 2024 · 2 comments · May be fixed by #4469
Labels
best practice rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards)
Milestone

Comments

@gabalafou
Copy link

Product

axe Extension

Product Version

4.79.3

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Note: I wrote up this issue based on the browser extension, but I also checked that this issue holds with the newer axe-core 4.9.1 using @axe-core/cli.

Expectation

The following URL should have zero landmark-unique violations:
https://pydata-sphinx-theme.readthedocs.io/en/latest/examples/kitchen-sink/generic.html

Actual

Axe finds several landmark-unique violations at the above URL.

These landmark-unique violations are for several <aside> tags on that page that are actually not represented by the latest browsers as role=complementary landmarks.

How to Reproduce

Using:

  • Chromium 124
  • axe DevTools v4.79.3 (axe-core 4.8.4)

Scan the following URL:
https://pydata-sphinx-theme.readthedocs.io/en/latest/examples/kitchen-sink/generic.html

Observe that the tool reports several instances of the landmark-unique violation.

Additional context

The latest browsers follow the HTML-role mapping specification and do not assign role=complementary to unnamed <aside> tags that are scoped to a sectioning content element (section 3.4.9).

But apparently Axe-core treats all <aside> tags in the document as landmarks, which triggers the landmark-unique violation.

For more context:

@gabalafou gabalafou added the ungroomed Ticket needs a maintainer to prioritize and label label May 14, 2024
@github-actions github-actions bot added the extension Axe Firefox or Chrome extension issues label May 14, 2024
@WilcoFiers
Copy link
Contributor

@gabalafou Thank you for reporting. I agree with your findings, and knowing this has been updated in the latest browsers now I see no reason for axe not to do the same thing. I'll add it to the 4.10 milestone. If you're interested, we'd welcome a pull request.

@WilcoFiers WilcoFiers added rules Issue or false result from an axe-core rule best practice standards Issues in the ARIA standards objects (lib/standards) and removed extension Axe Firefox or Chrome extension issues ungroomed Ticket needs a maintainer to prioritize and label labels May 15, 2024
@WilcoFiers WilcoFiers added this to the Axe-core 4.10 milestone May 15, 2024
@gabalafou
Copy link
Author

I created pull request #4469. This is my first pull request for Axe-core, so I doubt I got everything right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants