-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
landmark-unique seems to contradict W3C spec #4447
Labels
Comments
Thanks for the issue. This is an axe-core issue so I'm going to transfer it there. |
@TimCanu Thank you for reporting this. I agree with you, this is a reasonable exception that we didn't account for in the rule. Is this something you encountered on a live website? |
WilcoFiers
added
fix
Bug fixes
rules
Issue or false result from an axe-core rule
best practice
and removed
ungroomed
Ticket needs a maintainer to prioritize and label
labels
May 10, 2024
Hello @WilcoFiers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Product
playwright
Product Version
4.9.0
Latest Version
Issue Description
Expectation
Here is a code pen on which the issue is detailed. I don't know how to easily share this with playwright but a code like the following should yield the same error:
I have a table showing data. Above and below the table are one navigation landmark (both are identical). In such a situation, according to W3C:
If a specific landmark role is used more than once on a page, provide each instance of that landmark with a unique label. There is one rare circumstance where providing the same label to multiple instances of a landmark can be beneficial: the content and purpose of each instance is identical. For example, a large search results table has two sets of identical pagination controls -- one above and one below the table, so each set is in a navigation region labelled Search Results. In this case, adding extra information to the label that distinguishes the two instances may be more distracting than helpful.
So I don't expect the error "landmark-unique" for my
<nav>
s having the same aria-label...Actual
I have the error "landmark-unique": https://dequeuniversity.com/rules/axe/4.9/landmark-unique?application=playwright
How to Reproduce
code pen
If you consider that this is expected and wanted behaviour, what is your recommendation in such a case?
The text was updated successfully, but these errors were encountered: