-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive: 'color-contrast' rule fails disabled control's label added using "aria-describedby" attribute #4406
Comments
Thanks for the issue. From the screenshot I believe the issue is that the |
Hi @straker, thank you for the quick reply! Our |
Gotcha. I see what you mean. I'll have to ask the team about what should happen in these cases. I'll let you know when I get an answer. |
Amazing, thank you! |
I agree with @adrianaferrugento on this one. There's a very good chance that if a control is disabled, things related to that control are not intended to be used. Ignoring an element referenced with aria-describedby feels reasonable. I'd say aria-errormessage and aria-controls should get that treatment too. I think we should consider going a step further than that even and try to identify the container group (fieldset, radiogroup, etc), if all controls in a group are disabled, all text in it can be skipped in contrast testing. Either that or we set it as needs review. We'll look at that when we get to fixing this. |
Product
axe-core
Product Version
4.9.0
Latest Version
Issue Description
Same as 2090, but here the label is added using
aria-describedby
attributePer WCAG 1.4.3 the text that is part of an inactive user interface component do not have contrast requirement.
Expectation
'color-contrast' would not fail for labels related to disabled controls
Actual
'color-contrast' rule fails for a label( added using
aria-describedby
attribute) of a disabled controlHow to Reproduce
The text was updated successfully, but these errors were encountered: