-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't break on window.CSS === null #4400
Labels
Milestone
Comments
WilcoFiers
added
fix
Bug fixes
dependencies
Pull requests that update a dependency file
labels
Apr 4, 2024
Just for full context, |
gaiety-deque
added a commit
that referenced
this issue
May 9, 2024
patching colorio.js with optional chaining for `CSS?.supports` Refs: #4400
gaiety-deque
added a commit
that referenced
this issue
May 14, 2024
patching colorio.js with optional chaining for `CSS?.supports` Refs: #4400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Angular + Jest documentation recommends a solution which ends up setting
window.CSS
to null. This creates an issue when axe-core imports colorjs, which has a falsey check forwindow.CSS
, but whennull
errors out.Since ColorJS didn't accept our patch, we'll try to use patch-package to fix the issue ourselves. We'll need some tests to go along with that to confirm our solution continues to work after updating ColorJS.
patch-package should probably run in the build step, not as a post-install.
The text was updated successfully, but these errors were encountered: