Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALE linting .tsx as .ts files when using Biome #4752

Open
jbadavis opened this issue Apr 10, 2024 · 0 comments · May be fixed by #4773
Open

ALE linting .tsx as .ts files when using Biome #4752

jbadavis opened this issue Apr 10, 2024 · 0 comments · May be fixed by #4773
Labels
bug

Comments

@jbadavis
Copy link

Information

VIM version

VIM - Vi IMproved 9.1 (2024 Jan 02, compiled Feb 11 2024 17:19:45)
macOS version - arm64

Operating System: Mac OS 13.2.1

What went wrong

I've added and configured Biome for my React/Typescript project and I suspect ALE/Biome is linting my .tsx files as typescript files rather than typescriptreact files.

Reproducing the bug

  1. Clone https://github.com/jbadavis/jbadavis.dev.
  2. Checkout feat/biome.
  3. Open main.tsx and see the linting errors.

:ALEInfo

Expand

Current Filetype: typescriptreact
Available Linters: ['biome', 'cspell', 'deno', 'eslint', 'standard', 'tslint', 'tsserver', 'typecheck', 'xo']
Enabled Linters: ['biome']
Ignored Linters: []
Suggested Fixers:
'remove_trailing_lines' - Remove all blank lines at the end of a file.
'trim_whitespace' - Remove all trailing whitespace characters at the end of every line.
@jbadavis jbadavis added the bug label Apr 10, 2024
redbmk added a commit to redbmk/ale that referenced this issue May 13, 2024
@redbmk
fix(biome): send correct language to lsp proxy
f546106 
Since Biome understands `typescriptreact` and `javascriptreact` as
languages, we can send the `filetype` to the LSP, rather than only
sending `typescript` for both `ts` and `tsx` files, or `javascript` for
`js` and `jsx` files.

fixes: dense-analysis#4752
@redbmk redbmk linked a pull request May 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(biome): send correct language to lsp proxy redbmk/ale
1 participant
@jbadavis